Conversation
|
|
Pull Request Test Coverage Report for Build 4056884906Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lyz-code
left a comment
There was a problem hiding this comment.
Thanks for taking the time to fix all the yamls! :)
| pdm run flakeheaven lint src/ tests/ | ||
| $(isort) --check-only --df | ||
| $(black) --check --diff | ||
| yamllint . |
There was a problem hiding this comment.
Maybe use yamlfix --check instead
| pull_request: | ||
| types: [opened, synchronize] | ||
| workflow_dispatch: | ||
|
|
There was a problem hiding this comment.
The line length should be changed by yamlfix too. Look at the docs. Maybe it's a bug that it's not cropping it well
There was a problem hiding this comment.
If you don't feel like debugging the issue with the cropping, you can do it manually, but I wouldn't increase the line length either in yamlfix or in yamllint
There was a problem hiding this comment.
Yea, it must be a bug. I even tried setting that specifically and it did not work
There was a problem hiding this comment.
I've confirmed the bug and opened a new issue to track it. I'd say it's better to manually fix these comments so that we can merge the PR. What do you think?
Fixing yaml from #217
Checklist