Perform exclude glob only once per dir#294
Open
gilleswaeber wants to merge 1 commit intolyz-code:mainfrom
Open
Perform exclude glob only once per dir#294gilleswaeber wants to merge 1 commit intolyz-code:mainfrom
gilleswaeber wants to merge 1 commit intolyz-code:mainfrom
Conversation
Owner
|
Thanks @gilleswaeber for the change. The code looks much cleaner. I can't check that the code works though as the CI is not working. I know it's not your fault but I don't have time to fix it myself. If you could make the CI pass it would be a really nice gesture for the community. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the file enumeration method to only execute the glob once per dir instead of once per file. Does not change the behavior except that it will be much faster if using a dir to specify the location and glob exclude patterns that need to be evaluated over many files.
Additionally:
includethe include pattern which is always present since there is a default value therefore not optionalChecklist