Do not wait indefinitely for process to finish #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stopping thin with `bundle exec thin stop -f`, it sets timeout to 0 and if process does not die on `SIGINT`, it will never send `SIGKILL` because it waits indefinitely for it to die (`Timeout.timeout(0)`).
Collaborator
|
Sorry, but can you please rebase on master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stopping thin with
bundle exec thin stop -f, it sets timeout to0 and if process does not die on
SIGINT, it will never sendSIGKILLbecause it waits idefinitely for it to die (
Timeout.timeout(0)).