Skip to content

Enhanced cmd with arguments (also reflected in config.example.json) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhanced cmd with arguments (also reflected in config.example.json) #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions config/config.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,14 @@
"name": "Command Exec Button",
"address": "41:02:dc:b2:10:12",
"cmd": "/home/user/dash_button.sh"
},
{
"name": "WOL Button",
"address": "41:02:dc:b2:10:1f",
"cmd": "etherwake",
"args": [
"AA:AA:AA:BB:BB:BB",
"CC:CC:CC:DD:DD:DD"
]
}
]}
8 changes: 4 additions & 4 deletions lib/dasher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function DasherButton(button) {
doLog("Debug mode, skipping request.");
console.log(button);
} else if (typeof button.cmd !== 'undefined' && button.cmd != "") {
doCommand(button.cmd, button.name)
doCommand(button.cmd, button.args)
} else {
doRequest(button.url, button.method, options)
}
Expand All @@ -35,12 +35,12 @@ function DasherButton(button) {
doLog(button.name + " added.")
}

function doCommand(command, name, callback) {
const child = execFile(command, [name], (error, stdout, stderr) => {
function doCommand(command, args, callback) {
const child = execFile(command, args, (error, stdout, stderr) => {
if (error) {
// Stripping a trailing new line
output = stderr.replace (/\s+$/g, "");
doLog(`There was an error: ${output}`);
doLog(`There was an error: ${output}`);
}

if (stdout != "") {
Expand Down