Add page navigation timeout argument to generator

[mattc321]

Let's give users the chance to change the page timeout while generating. Pupeteer's default timeout is not always enough and can lead to false failures while generating.

[Meberem]

I would love to use this PR now. I am battling a very slow checkout page in dev (no idea why) but upping the timeout seems to do wonders. Thanks

[friendscottn]

@Meberem you can try this to use the PR with the timeout:

npm uninstall -g magepack
npm install -g https://github.com/beebots/magepack.git

Also if that doesn't work out you can try throwing a --debug on your magepack generate command. This seems to increase the timeout on it's own.

[Meberem]

@Meberem you can try this to use the PR with the timeout:

npm uninstall -g magepack
npm install -g https://github.com/beebots/magepack.git

Also if that doesn't work out you can try throwing a --debug on your magepack generate command. This seems to increase the timeout on it's own.

Thank the linked repo/module works great with the --timeout option.

Weirdly I had an error

 ERROR  Failed to launch the browser process!                                                                                                                                                                                   10:57:50
[4211:4211:0817/105750.605590:ERROR:browser_main_loop.cc(1386)] Unable to open X display.


TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md


  [4211:4211:0817/105750.605590:ERROR:browser_main_loop.cc(1386)] Unable to open X display.
  
  
  TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md
  
  at onClose (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/Launcher.js:750:14)
  at ChildProcess.<anonymous> (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/Launcher.js:740:61)
  at ChildProcess.emit (events.js:327:22)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

When adding the --debug flag to either implementation. I suspect that is because I am running under WSL and no "window" can be opened.

Either way the PR does the trick, thanks!

[krzksz]

Hey, thanks for giving back and contributing. Also, sorry it took me so much time to check this as I'm no longer involved into Magento projects.

Can you please adjust the code I mentioned and add the information about this option to the appropriate section in the README.md?

[cmorbitzer]

@krzksz Are there plans to merge this?