Fixed type of message for Toast.show function.#150
Closed
AndreasA wants to merge 1 commit intomagicismight:masterfrom
AndreasA:fix/correct-type-for-message
Closed
Fixed type of message for Toast.show function.#150AndreasA wants to merge 1 commit intomagicismight:masterfrom AndreasA:fix/correct-type-for-message
AndreasA wants to merge 1 commit intomagicismight:masterfrom
AndreasA:fix/correct-type-for-message
Conversation
Author
|
I just found there is annother PR that fixes the type and does some additional stuff regarding ReactNode. #111 not sure, if the additional stuff is necessary or not because ReactNode seems to already work correctly, except the type, which is why I keep this PR open until feedback by maintainers |
MarkWissler
approved these changes
Feb 25, 2022
|
Can we merge this? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: #123