Skip to content

Added :threshold option, and added ymail.com to DOMAINS #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adaminglehart wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added :threshold option, and added ymail.com to DOMAINS #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/mailcheck.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ class Mailcheck

THRESHOLD = 3

DOMAINS = ['yahoo.com', 'google.com', 'hotmail.com', 'gmail.com', 'me.com', 'aol.com', 'mac.com', 'live.com', 'comcast.net', 'googlemail.com', 'msn.com', 'hotmail.co.uk', 'yahoo.co.uk', 'facebook.com', 'verizon.net', 'sbcglobal.net', 'att.net', 'gmx.com', 'mail.com']
DOMAINS = ['yahoo.com', 'google.com', 'hotmail.com', 'gmail.com', 'me.com', 'aol.com', 'mac.com', 'live.com', 'comcast.net', 'googlemail.com', 'msn.com', 'hotmail.co.uk', 'yahoo.co.uk', 'facebook.com', 'verizon.net', 'sbcglobal.net', 'att.net', 'gmx.com', 'mail.com', 'ymail.com']

TOP_LEVEL_DOMAINS = ['co.uk', 'com', 'net', 'org', 'info', 'edu', 'gov', 'mil']

def initialize(opts = {})
@domains = opts[:domains] || DOMAINS
@top_level_domains = opts[:top_level_domains] || TOP_LEVEL_DOMAINS
@threshold = opts[:threshold] || THRESHOLD
end

def suggest(email)
Expand Down Expand Up @@ -55,7 +56,7 @@ def find_closest_domain(domain, domains)
end
end

if min_dist <= THRESHOLD && closest_domain
if min_dist <= @threshold && closest_domain
closest_domain
else
nil
Expand Down