Automatic pruning of LRU cache #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What if we auto prune after X number of evictions? |
Contributor
Author
That's worth a try. |
Contributor
Author
|
Abandoning as not necessary. I was not able to isolate the root cause reliably in tests. Moreover, there has been reports of a memory leak in Golang that has been fixed since 1.22 that may impact Groupcache peer communication. After updating a test project from Golang 1.22 to 1.24 and an unnecessary call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRU cache is based on a
map. Each new unique key added expandsmapcapacity.maps do not shrink even after those keys are deleted. For scenarios with high frequency adds and high cardinality this manifests over time as a memory leak.