This repository was archived by the owner on Apr 17, 2020. It is now read-only.
Open
Conversation
mansona
previously approved these changes
Apr 9, 2020
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I think this looks good 🤔 I'm not too familiar with the project itself but I checked and there are at least some tests so I am assuming if there was anything that's using lodash it is exercised in there and we would catch any issues 👍
This was referenced Apr 9, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing all these updates before releasing 1.0 as some updates might technically be considered breaking changes (I think ember-cli-babel is technically breaking?)