Skip to content

Fixed transaction invocation serialization #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZhmakAS wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed transaction invocation serialization #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
661cf00
CSDK/fixed_transaction_invocation_serialization
ZhmakAS Feb 27, 2026
8416e84
CSDK/fixed_transaction_invocation_serialization
ZhmakAS Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 40 additions & 34 deletions types/transaction_invocation_target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,19 @@ func (t *TransactionInvocationTarget) Bytes() ([]byte, error) {
return nil, err
}

var protocolMajorBytes []byte
if t.ByPackageHash.ProtocolVersionMajor != nil {
versionBytes = []byte{1} // Option Some tag
bytes, _ := encoding.NewU32ToBytesEncoder(*t.ByPackageHash.ProtocolVersionMajor).Bytes()
protocolMajorBytes = append(versionBytes, bytes...)
} else {
protocolMajorBytes = []byte{0} // Option none tag
}

if err = builder.AddField(ByPackageHashProtocolVersionMajorIndex, protocolMajorBytes); err != nil {
return nil, err
var protocolMajorBytes []byte
if t.ByPackageHash.ProtocolVersionMajor != nil {
versionBytes = []byte{1} // Option Some tag
bytes, _ := encoding.NewU32ToBytesEncoder(*t.ByPackageHash.ProtocolVersionMajor).Bytes()
protocolMajorBytes = append(versionBytes, bytes...)
} else {
protocolMajorBytes = []byte{0} // Option none tag
}

if err = builder.AddField(ByPackageHashProtocolVersionMajorIndex, protocolMajorBytes); err != nil {
return nil, err
}
}
case t.ByPackageName != nil:
if err = builder.AddField(TagFieldIndex, []byte{ByPackageNameVariant}); err != nil {
Expand All @@ -133,17 +135,19 @@ func (t *TransactionInvocationTarget) Bytes() ([]byte, error) {
return nil, err
}

var protocolMajorBytes []byte
if t.ByPackageName.ProtocolVersionMajor != nil {
versionBytes = []byte{1} // Option Some tag
bytes, _ := encoding.NewU32ToBytesEncoder(*t.ByPackageName.ProtocolVersionMajor).Bytes()
protocolMajorBytes = append(versionBytes, bytes...)
} else {
protocolMajorBytes = []byte{0} // Option none tag
}

if err = builder.AddField(ByPackageNameProtocolVersionMajorIndex, protocolMajorBytes); err != nil {
return nil, err
var protocolMajorBytes []byte
if t.ByPackageName.ProtocolVersionMajor != nil {
versionBytes = []byte{1} // Option Some tag
bytes, _ := encoding.NewU32ToBytesEncoder(*t.ByPackageName.ProtocolVersionMajor).Bytes()
protocolMajorBytes = append(versionBytes, bytes...)
} else {
protocolMajorBytes = []byte{0} // Option none tag
}

if err = builder.AddField(ByPackageNameProtocolVersionMajorIndex, protocolMajorBytes); err != nil {
return nil, err
}
}
default:
return nil, errors.New("unknown transaction invocation target")
Expand Down Expand Up @@ -175,34 +179,36 @@ func (t *TransactionInvocationTarget) serializedFieldLengths() []int {
versionSerializedLength = encoding.U32SerializedLength
}

var protocolMajorSerializedLength int
if t.ByPackageHash.ProtocolVersionMajor != nil {
protocolMajorSerializedLength = encoding.U32SerializedLength
}

return []int{
serializedLength := []int{
encoding.U8SerializedLength,
key.ByteHashLen,
encoding.U8SerializedLength + versionSerializedLength,
encoding.U8SerializedLength + protocolMajorSerializedLength,
}

if t.ByPackageHash.ProtocolVersionMajor != nil {
protocolMajorSerializedLength := encoding.U32SerializedLength
serializedLength = append(serializedLength, encoding.U8SerializedLength+protocolMajorSerializedLength)
}

return serializedLength
case t.ByPackageName != nil:
var versionSerializedLength int
if t.ByPackageName.Version != nil {
versionSerializedLength = encoding.U32SerializedLength
}

var protocolMajorSerializedLength int
if t.ByPackageName.ProtocolVersionMajor != nil {
protocolMajorSerializedLength = encoding.U32SerializedLength
}

return []int{
serializedLength := []int{
encoding.U8SerializedLength,
encoding.StringSerializedLength(t.ByPackageName.Name),
encoding.U8SerializedLength + versionSerializedLength,
encoding.U8SerializedLength + protocolMajorSerializedLength,
}

if t.ByPackageName.ProtocolVersionMajor != nil {
protocolMajorSerializedLength := encoding.U32SerializedLength
serializedLength = append(serializedLength, encoding.U8SerializedLength+protocolMajorSerializedLength)
}

return serializedLength
default:
return []int{}
}
Expand Down