Skip to content

Dhruvkhanna/code cleanup #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dhruvkhanna38 wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Dhruvkhanna/code cleanup #151

dhruvkhanna38 wants to merge 34 commits into from

Conversation

@dhruvkhanna38
Copy link

@dhruvkhanna38 dhruvkhanna38 commented Jun 20, 2023 •
edited
Loading

Jennifer Mankoff and others added 30 commits February 22, 2022 17:38
Merge branch 'noramorsi/handlers'
31fdffb
Buggy alternative way to do slope
f03a213
Added a slope demo that plays a tone representing the current slope
0e18f8c
jen's in-progress code
e26230b
@venkateshpotluri
partial bug fix.
bb45ddf
commitment for venkatesh
507e051
Merge branch 'origin/jen-architecting' of https://github.com/make4all…
1977415 
…/sonification into jen/testing
@noramorsi
basic set up of keyboard page; onclick not triggering
13d55f6
@noramorsi
set up space in page for focus
add2387
@noramorsi
mapping created
2ea1731
@noramorsi
tones playing, need to fix auto-play
ae41e2d
@noramorsi
attempt at fixing tones continuing
6d02a38
@noramorsi
basic keyboard visual set up, no change visually
01572c8
@noramorsi
note ends when key up
cbcffaf
@noramorsi
style changes
6e92b06
@noramorsi
black keys added, do not wrap like white keys
629c684
@noramorsi
shifted down an octave
add9735
@noramorsi
single octave with black keys included
08c1832
@noramorsi
cleaning up constants
80a44fd
@noramorsi
mouse position sonification demo added
0df7913
@noramorsi
expanded to include 3rd octave
9884cb9
@venkateshpotluri
buggy running average code.
31f8c2d
@venkateshpotluri
debugging logs.
af41f7e
@venkateshpotluri
almost done piano.
06ae208
@dhruvkhanna38
Created a new path /DemoCopyStream with button to copy data collected…
98467ef 
… from microbit as .csv
@dhruvkhanna38
feature: CopyToClipboardHandler add to dashboard.tsx
946db22
@dhruvkhanna38
Merge branch 'noramorsi/keyboard' into dhruvkhanna/code-cleanup
30e2568
@dhruvkhanna38
Merge branch 'origin/jen-architecting' into dhruvkhanna/code-cleanup
ca27c18
@dhruvkhanna38
fix: build
86bf3ed
@dhruvkhanna38
Merge branch 'dhruvkhanna/demo-copy-stream' into dhruvkhanna/code-cle…
53e1c22 
…anup
@venkateshpotluri
Copy link
Contributor

venkateshpotluri commented Oct 4, 2023 •
edited by dhruvkhanna38
Loading

Please perform the following tests before we merge. Possible include these as test cases that could run as a part of the CI/CD pipeline.

  • check the keyboard demo on the dashboard.
  • in a separate code file, try chaining handelers and test if those work. e.g. a filter range handeler with a sound effect.
  • test handeler-output combinations using the dashboard to ensure nothing breaks.

@dhruvkhanna38
Copy link
Author

dhruvkhanna38 commented Oct 9, 2023

@venkateshpotluri the tests above are working for this pull request. It is good to merge.

I removed some deprecated code and updated the comments for some of the classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@venkateshpotluri venkateshpotluri Awaiting requested review from venkateshpotluri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhruvkhanna38 @venkateshpotluri @noramorsi