-
Notifications
You must be signed in to change notification settings - Fork 0
Redux Saga Implementation #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javier-pepe
wants to merge
32
commits into
develop
Choose a base branch
from
feature-redux-saga
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature-redux-saga
…ctlyTraining into feature-redux-saga
add url utilities feature-redux-sagas
fix export path feature-redux-saga
…educer must be a generator funcion erroradd generators testsadd reducers testsfeature-redux-saga
…aining/DirectlyTraining into feature-redux-saga merge in remote
add babel regenerator add babel polyfill feature-redux-saga
fix store init add missing action getUsers update tests implement users selector fix users selector feature-redux-saga
implement selectors add selector missing tests updated components feature-redux-saga
fearure-redux-saga
improve coverage feature-redux-saga
add select functionality add mising tests feature-redux-saga
feature-redux-saga
update tests to make them less brittle feature-redux-saga
sagas generators does not support await feature-redux-saga
add createUsers add updateUsers add deleteUsers improve tests update title feature-redux-saga
feature-redux-saga
feature-redux-saga
feature-redux-saga
improved coverage add missing tests feature-redux-saga
add lodash replacement helpers w/no dependencies add tests feature-redux-saga
add babel dependencies add eslint dependencies update tests improve brittle tests feature-redux-saga
…Componentfeature-redux-saga
use prevState instead update remote api endpoint feature-redux-saga
feature-redux.saga
remove bindings rename render named methods update setState references implement Purecomponent feature-redux-saga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h3. Description
Initial implementation of redux-sagas
CRUD working, stable version
Changes
Implemented Redux Sagas
...review commits for change details
TODO
add async/await support to sagas, i.e. trigger several effects like loading, call services, resolve Once from saga with result of the service response. Currently the root saga returns immediately. We need to mimic the initial Promise based behavior. Call an action, perform services requests, resolve Only and When the service responded, this is a must for Create, Update And Delete operations.
h3. Screenshots

h3. Coverage
