Added error boundary and error middleware #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuelmetal
commented
Jul 30, 2018
webapp/app/services/userService.js
Outdated
|
|
||
| export function fetchUsers(params = {}) { | ||
| return axios.get(DEFAULT_API_USERS_ENDPOINT, { params }); | ||
| return axios.get(DEFAULT_API_USERS_ENDPOINT + 'asd', { params }); |
emanuelmetal
commented
Jul 30, 2018
| // <App />, | ||
| // document.getElementById('root') | ||
| // ); | ||
| // |
Member
Author
There was a problem hiding this comment.
Remove commented code
emanuelmetal
commented
Jul 30, 2018
webapp/app/store/errorsMiddleware.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| // eslint-disable-next-line no-unused-vars | |||
| const errorsMiddleware = store => next => action => { | |||
emanuelmetal
commented
Jul 30, 2018
webapp/app/utils/errorService.js
Outdated
| export function logErrors(message, file, line = 'N/A', col = 'N/A') { | ||
| Logger.error(`An Error Occurred!!: message[${message}], file[${file}], line[${line}], col[${col}]`); | ||
| export function logErrors(error) { | ||
| // Logger.error(`An Error Occurred!!: message[${message}], file[${file}], line[${line}], col[${col}]`); |
Member
Author
There was a problem hiding this comment.
Remove this comented code
RamiroGonzalez89
approved these changes
Jul 31, 2018
emanuelmetal
added
Feature
mravinale
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We need to improve Error handling in the app by using a react error boundary component and, an error middlware to log each filed request.
Changes done