fix: use HTTPS for Testing/Data submodule#199
Open
liamnwhite1 wants to merge 1 commit intomalaterre:masterfrom
Open
fix: use HTTPS for Testing/Data submodule#199liamnwhite1 wants to merge 1 commit intomalaterre:masterfrom
liamnwhite1 wants to merge 1 commit intomalaterre:masterfrom
Conversation
The nested submodule for test data currently uses git://git.code.sf.net/p/gdcm/gdcmdata (port 9418). Many corporate and CI environments block the git protocol, which causes recursive submodule fetches to hang or fail. Switching to HTTPS makes the fetch work reliably behind firewalls and within tools that disable the git protocol. - Update .gitmodules to use https://git.code.sf.net/p/gdcm/gdcmdata.git - Recommend `git submodule sync --recursive` for existing clones This change is read-only and does not affect code or tests—only how the public submodule is fetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nested submodule for test data currently uses
git://git.code.sf.net/p/gdcm/gdcmdata(port 9418). Many corporate and CI environments block the git protocol, which causes recursive submodule fetches to hang or fail. Switching to HTTPS makes the fetch work reliably behind firewalls and within tools that disable the git protocol.https://git.code.sf.net/p/gdcm/gdcmdata.gitgit submodule sync --recursivefor existing clonesThis change is read-only and does not affect code or tests—only how the public submodule is fetched.