Skip to content

Comments

ENH: Conform GDCM to support CMAKE_*OUTPUT_DIRECTORY#201

Open
blowekamp wants to merge 1 commit intomalaterre:masterfrom
blowekamp:cmake_output_paths
Open

ENH: Conform GDCM to support CMAKE_*OUTPUT_DIRECTORY#201
blowekamp wants to merge 1 commit intomalaterre:masterfrom
blowekamp:cmake_output_paths

Conversation

@blowekamp
Copy link
Contributor

Recommend users using modern CMAKE_*_OUTPUT_DIRECTORY variables to configure paths.

Prioritize legacy variables only if set by the user. Removes setting legacy CMake variable such as EXECUTE_OUTPUT_PATH and LIBRARY_OUTPUT_PATH as cache variables. Add support for modern CMAKE_*_OUTPUT_DIRECTORY variables, if they are set by the user.

Recommend users using modern CMAKE_*_OUTPUT_DIRECTORY variables to
configure paths.

Prioritize legacy variables only if set by the user. Removes
setting legacy CMake variable such as EXECUTE_OUTPUT_PATH and
LIBRARY_OUTPUT_PATH as cache variables. Add support for
modern CMAKE_*_OUTPUT_DIRECTORY variables, if they are set by the
user.
@blowekamp
Copy link
Contributor Author

@malaterre @hjmjohnson @thewtex Please review.

Copy link
Contributor

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants