Fix 574: CVE 2025 52582 Prevent grabbing overaly from pixel data if information data is not persistent#204
Closed
pierreldff wants to merge 3 commits intomalaterre:masterfrom
Conversation
Owner
|
@pierreldff Thank you ! applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose to perform the verification in the PixmapReader object instead of the Overlay one because the PixmapReader has access to the image information, and it is the only place where Overlay::GrabOverlayFromPixelData is called.
I added Doxygen documentation to warn users against using the GrabOverlayFromPixelData method directly.