-
Notifications
You must be signed in to change notification settings - Fork 5
fix: add data validate missing verification #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
karl-dz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an SVM program test to confirm that validate catches invalid input when this instruction is called? Thank you
Sure! |
|
Hi @karl-dz , just pushed some new changes w/ SVM tests. Can you please review this? Thanks |
|
For some reason there is a go-lint error. Can you rebase and push to your branch? I can run the workflows again when you do. Thank you |
for sure! sorry for delaying this change for this long, was busy with university examinations. |
752f2e7 to
5bd4efe
Compare
|
This change has already been addressed in other PRs. Thank you for your continued and consistent contributions to DoubleZero. |
awesome! thankyou too! |
Summary of Changes
Testing Verification
Fixes #2239