Skip to content

Perf/allocation optimizations for FastLabelPropagationCommunityDetector.AssignLabels #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KSemenenko merged 3 commits into from
Dec 6, 2025
Merged

Perf/allocation optimizations for FastLabelPropagationCommunityDetector.AssignLabels #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38c0f79
Delete Cache benchmark, as it is not adding any value
gmanvel Dec 3, 2025
1d3cb8e
Adding test coverage for FastLabelPropagationCommunityDetector.Assign…
gmanvel Dec 4, 2025
feb6294
Merge branch 'managedcode:main' into main
gmanvel Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 0 additions & 99 deletions benchmarks/ManagedCode.GraphRag.Benchmarks/Cache/MemoryPipelineCacheBenchmarks.cs
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion benchmarks/ManagedCode.GraphRag.Benchmarks/Community/FastLabelPropagationBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
namespace ManagedCode.GraphRag.Benchmarks.Community;

[MemoryDiagnoser]
[HideColumns("Error", "StdDev", "RatioSD")]
public class FastLabelPropagationBenchmarks
{
private EntityRecord[] _smallGraphEntities = null!;
Expand Down Expand Up @@ -41,7 +42,7 @@ public void Setup()
(_largeGraphEntities, _largeGraphRelationships) = GenerateGraph(10_000, 5);
}

[Benchmark]
[Benchmark(Baseline = true)]
public IReadOnlyDictionary<string, string> SmallGraph()
{
return FastLabelPropagationCommunityDetector.AssignLabels(
Expand Down
12 changes: 7 additions & 5 deletions src/ManagedCode.GraphRag/Community/FastLabelPropagationCommunityDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,23 @@ public static IReadOnlyDictionary<string, string> AssignLabels(

var random = new Random(config.Seed);
var labels = adjacency.Keys.ToDictionary(node => node, node => node, StringComparer.OrdinalIgnoreCase);
var nodes = adjacency.Keys.ToList();
var nodes = adjacency.Keys.ToArray();
var maxIterations = Math.Max(1, config.MaxIterations);

for (var iteration = 0; iteration < maxIterations; iteration++)
{
var shuffled = nodes.OrderBy(_ => random.Next()).ToList();
random.Shuffle(nodes);
var changed = false;

foreach (var node in shuffled)
var labelWeights = new Dictionary<string, double>(StringComparer.OrdinalIgnoreCase);
foreach (var node in nodes)
{
var neighbors = adjacency[node];
if (neighbors.Count == 0)
{
continue;
}

var labelWeights = new Dictionary<string, double>(StringComparer.OrdinalIgnoreCase);
foreach (var (neighbor, weight) in neighbors)
{
if (!labels.TryGetValue(neighbor, out var neighborLabel))
Expand All @@ -57,7 +57,7 @@ public static IReadOnlyDictionary<string, string> AssignLabels(

var maxWeight = labelWeights.Values.Max();
var candidates = labelWeights
.Where(pair => Math.Abs(pair.Value - maxWeight) < 1e-6)
.Where(pair => Math.Abs(pair.Value - maxWeight) < double.Epsilon)
.Select(pair => pair.Key)
.ToList();

Expand All @@ -70,6 +70,8 @@ public static IReadOnlyDictionary<string, string> AssignLabels(
labels[node] = chosen;
changed = true;
}

labelWeights.Clear();
}

if (!changed)
Expand Down
Loading