Fix libraries.python3.vm dependency resolution#1554
Merged
Conversation
emtuls
added
🐛 bug
emtuls
force-pushed
the
fix-librariespython3
branch
from
d4df3ca to
bbaeca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our
libraries.python3.vmpackage fails to install on the Github Runner, likely due to silentpipthings with the OS versions, but I've been unable to confirm the exact reason, but it works fine locally on my Windows 10 VM, so this would be my logical guess.This fix aims to make it always work and also fixes potential issues that could arise even on a not as up to date VM as it will resolve dependencies across all modules being installed in the list.
NOTE: We will still potentially fail if we keep the same python version across each tool that installs via
pipin its own contained package due topipbeing unable to track dependencies properly. Though if we do go the route of keeping some individually installed tools pinned to an older python version, as somewhat suggested in #1547 then we might not have too many problems that arise due to separate interpreters mitigating the issue for us.