vmray: skip processes with invalid PID or missing filename (#2807)

[EclipseAditya]

Summary

Fixes #2807

Changes

• Added validation in VMRayExtractor.get_processes() to skip invalid/incomplete monitor process entries where:
  • pid == 0 (system process)
  • filename is empty or missing (incomplete record)

Testing

• All VMRay tests pass (36/36)
• Follows the same pattern used in the DRAKVUF extractor

Notes

The pre-commit hooks show some failures (flake8 UnicodeDecodeError, mypy error in idalib.py) but these are pre-existing issues in the repository, not related to this PR.

[gemini-code-assist]

Summary of Changes

Hello @EclipseAditya, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of the VMRay feature extractor by implementing a new validation step. It ensures that only well-formed and complete process entries are considered, preventing potential issues from malformed or system-level process data. This change improves the robustness of the extraction process and aligns its behavior with established patterns in other extractors.

Highlights

• Process Validation: Introduced validation within the VMRayExtractor.get_processes() method to filter out invalid or incomplete monitor process entries.
• Skipped Processes: Processes with a PID of 0 (system processes) or those lacking a filename are now explicitly skipped to ensure data integrity.
• Debugging Support: Added logging for skipped processes, providing debug information including PID, filename, and monitor ID, to assist in troubleshooting.
• Changelog Update: The CHANGELOG.md file has been updated to reflect this new feature, crediting the author and linking to the relevant issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where processes with invalid PIDs or missing filenames were not being skipped. The changes in capa/features/extractors/vmray/extractor.py add the necessary validation in get_processes to filter out these invalid entries, along with a helpful debug log message. The implementation is clean, targeted, and follows best practices. The update to CHANGELOG.md is also appropriate. Overall, this is a good fix.

[EclipseAditya]

Hello @mr-tz and @mike-hunhoff ,
When you get some time, could you please review this PR? Thanks a lot!

[mike-hunhoff]

great, thanks @EclipseAditya