ci: Reject PRs without CHANGELOG update#584
Merged
Ana06 merged 5 commits intomandiant:masterfrom May 28, 2021
Merged
Conversation
Ana06
added a commit
to Ana06/capa
that referenced
this pull request
May 27, 2021
Ana06
added a commit
to Ana06/capa
that referenced
this pull request
May 27, 2021
williballenthin
approved these changes
May 27, 2021
mr-tz
approved these changes
May 28, 2021
| - [ ] I have made the corresponding changes to the documentation | ||
|
|
||
| ### Tests | ||
| ### Checklist |
Collaborator
There was a problem hiding this comment.
it's more an "Unchecklist" 😉
Member
Author
|
It seems there are now plans to release |
Collaborator
|
Up to you. Feel free to merge and maybe create an issue to update once it's available. Thanks for all the Actions R&D! |
After using the PR template for a while, I think simplifying it will be helpful: - GitHub includes the commit message description automatically with the aim of saving you time as it is sometimes also a good PR description. With the current template, I need to cut this test and paste it into the description section (which is really annoying!). - Make a single simpler checklist. Add information as comment and have a straightforward list which helps us remembering the changelog, tests and documentation without needing to invest much time. The changelog bulletpoint will also be used in GitHub Actions.
Request changes in a PR without CHANGELOG update.
`Ana06/automatic-pull-request-review@v0.1.0` is a fork of https://github.com/AndrewMusgrave/automatic-pull-request-review which fixes `DISMISS` and provides an `allow_duplicate` option which allows to only approve once.
Ana06/get-changed-files@v1.1 is a fork of https://github.com/jitterbit/get-changed-files, which supports `pull_request_target` and allow to filter files using regular expressions. As we need to use `pull_request_target`, Ana06/get-changed-files@v1.1 works, but jitterbit/get-changed-files@v1 doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a proposal to improve the pull request template and a GitHub Action to reject pull requests which don't update the CHANGELOG. The Action dismiss the request once the CHANGELOG has been updated or
No CHANGELOG update neededhas been marked in the PR description.Closes #457
You can see it working here: Ana06#36
Note I needed to fork and release my own versions of
get-changed-filesandautomatic-pull-request-review. I tried to submited my code upstream, but I didn't get an answer. In case you want to review that code:Checklist