Conversation
SeraphCoding
force-pushed
the
SeraphCoding-switch-to-@use
branch
from
dff02d7 to
02b1f6d
Compare
global built in functions are deprecated
SeraphCoding
force-pushed
the
SeraphCoding-switch-to-@use
branch
from
da85c6e to
8fc235e
Compare
|
@marella Could you take a look at this PR, please? It should (in theory) be a quick one. |
|
Please can this be merged :'( ? |
|
Don't think this will happen anytime soon. Maintainer seems to be busy. I've moved my projects to Fontsource. The different material symbols versions can be found here: |
JuNe98
left a comment
JuNe98
left a comment
There was a problem hiding this comment.
You should change the suggested code. Everything else looks good
| @import 'core'; | ||
| @use 'core'; | ||
|
|
||
| @include material-symbols-font('Material Symbols Outlined'); |
There was a problem hiding this comment.
You have to add the namespace core here according to https://sass-lang.com/documentation/at-rules/use/#loading-members.
@include core.material-symbols-font('Material Symbols Outlined');
| @import 'core'; | ||
| @use 'core'; | ||
|
|
||
| @include material-symbols-font('Material Symbols Rounded'); |
There was a problem hiding this comment.
You have to add the namespace core here according to https://sass-lang.com/documentation/at-rules/use/#loading-members as well.
@include core.material-symbols-font('Material Symbols Rounded');
| @import 'core'; | ||
| @use 'core'; | ||
|
|
||
| @include material-symbols-font('Material Symbols Sharp'); |
There was a problem hiding this comment.
You have to add the namespace core here according to https://sass-lang.com/documentation/at-rules/use/#loading-members as well.
@include core.material-symbols-font('Material Symbols Sharp');
| @import 'outlined'; | ||
| @import 'rounded'; | ||
| @import 'sharp'; | ||
| @use 'outlined'; |
There was a problem hiding this comment.
It is better to use @forward instead of @use in side an index file. @forward takes your modules into an index file and then spits them out again.
Please have a look at the documentation https://sass-lang.com/documentation/at-rules/forward
|
Hi @SeraphCoding, |
4 participants
The usage of
@importhas been deprecated.Global built in functions are also deprecated.
This PR imports sass:string and uses string.to-lower-case instead and changes all
@importrules to@useinstead.Angular 19 will throw warnings during compilation - this fixes this issue.
Closes #44