fix: resolve memory leak in CPU destructors#28
Merged
Conversation
Fix double-delete bug where m_qk was allocated in base class CPU constructor but deleted in derived class destructors (CPURV32/CPURV64). Changes: - Move m_qk deletion from derived class destructors to base class CPU destructor where it was originally allocated - Add null pointer checks before all delete operations in destructors - Set pointers to nullptr after deletion for safety - Add comments explaining cleanup responsibility This fixes: - Double-delete bug that could cause undefined behavior - Potential memory leaks from improper cleanup order - Missing null pointer safety checks Files modified: - inc/CPU.h: Changed base class destructor from =default to proper implementation - src/CPU.cpp: Added base class destructor to delete m_qk - src/RV32.cpp: Removed m_qk deletion, added null checks - src/RV64.cpp: Removed m_qk deletion, added null checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double-delete bug where m_qk was allocated in base class CPU constructor but deleted in derived class destructors (CPURV32/CPURV64).
Changes:
This fixes:
Files modified: