Only delete cache directories, not all that are found #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the cache cleaning logic to only delete directories that match cache patterns, preventing unintended deletion of non-cache directories during cleanup operations.
Key Changes:
- Filters findings to only include those with a non-empty
Patternfield before deletion - Updates size calculations and display logic to reflect only cache directories
- Adds check to prevent deletion when no cache directories are found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
markcallen
force-pushed
the
chore/only_delete_cache_dirs
branch
from
ed706bd to
a48c933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cache cleaning logic to only delete cache directories, not all directories that are found.
Changes
Related
chore/only_delete_cache_dirs