Add ability to use remote management with configurable identities #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure remote management of LXMF propagation nodes using a configurable list of remote identity hashes, similar to the way it works for reticulum transport nodes.
It adds two options to the configuration file:
remote_management_enabled- boolean to quickly enable or disable this featureremote_management_identities- comma separated list of identity hexhashes which are allowed to call management endpointsAfaik currently the node stats request endpoint is the only one available.
There are checks for the validity of the provided hashes (same code as used everywhere in reticulum).
The node's own identity is also automatically added to the list of allowed hashes regardless of configuration, so that this feature continues to work exactly like it does today for backwards compatibility.