Throw exception if route cannot be parsed#36
Open
jkone27 wants to merge 2 commits intomarkvincze:mainfrom
Open
Throw exception if route cannot be parsed#36jkone27 wants to merge 2 commits intomarkvincze:mainfrom
jkone27 wants to merge 2 commits intomarkvincze:mainfrom
Conversation
Author
|
I see this doesn't cover some cases e.g. with query parameters.. probably the regex need to be adapted to fit this scope.. maybe then the "ignore broken route" solution in the other PR for now is better as a "quick fix" while looking for a "better" solution for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This throws if aspnet is unable to parse the route as a valid template,
i think this is acceptable as it signals the developer to fix the test setups.
just added a validation in the constructor here:
so this test can be green