Search to the last possible match of regexp in reverse search#45
Merged
marlon-sousa merged 1 commit intomasterfrom Jul 13, 2025
Merged
Conversation
marlon-sousa
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #42 .
This is an attempt to fix issue #42 by searching all possible matches of a regexp. When a match is found, it tries to search from the character following the match onto the start offset, to fix the greedy case described on the issue. This currently needs more testing to check if this solution works with more regular expressions, but for the described test case found on the issue it works, so I am marking in draft status for now.