Feature/dev live reload #322
Open
+436
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LiveReload middleware for injecting WebSocket client script - Add live reload settings to GlobalSettings - Update server to start live reload server in development mode - Fix WebSocket client handling in live reload server - Add comprehensive tests for live reload functionality
- Update middleware test to match SSE implementation - Add handler tests for SSE endpoint - Fix server tests for file watching - Update deprecated sleep calls to use Time::Span
- Fix event handler reassignment in live reload script - Update middleware test to use call instead of chain
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
Hey! 👋 Thanks a lot for opening this PR! I agree that live reloading could be useful for some Marten projects. However, I’m not sure it’s something that should live within the framework itself — many projects can (and do) use external tools for live- or hot-reloading, and the need might not be common enough to justify maintaining it as part of Marten. I think it would make a great standalone shard though. Would you be open to creating one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.