Conversation
I have added order_bolts() to return an ordered list of bolts (clockwise from top) that slots in pretty well, iI can put it into ret_centres() at a later date as it isn't really necessary to have a separate function, let me know your thoughts
msekatchev
reviewed
May 29, 2020
| bolt_no = 0 | ||
| for i in bolts_ord : | ||
| bolt_no += 1 | ||
| cv2.putText(img, f'{bolt_no}', (i[1], i[0]), cv2.FONT_HERSHEY_SIMPLEX, 1, (255,255,255), 1) |
Contributor
There was a problem hiding this comment.
Changed to a different color to make numbers visible against the white bolt masks
msekatchev
approved these changes
May 29, 2020
Contributor
msekatchev
left a comment
msekatchev
left a comment
There was a problem hiding this comment.
Worked for me, thank you Dan.
I made a few small changes that I will add in another merge later, mainly:
Changed L = int(r*1.1) to L = int(r*1.5) in ret_centres(), which worked better for detecting all the bolts around my radius 120 PMT (wasn't detecting all of them before).
Changed the text mask color to make the numbers more visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added order_bolts() to return an ordered list of bolts (clockwise from top) that slots in pretty well, I can put it into ret_centres() at a later date as it isn't really necessary to have a separate function, let me know your thoughts