Improved bolt labels and added pmt-id labels on output mask#4
Open
msekatchev wants to merge 3 commits intomartindgr:masterfrom
Open
Improved bolt labels and added pmt-id labels on output mask#4msekatchev wants to merge 3 commits intomartindgr:masterfrom
msekatchev wants to merge 3 commits intomartindgr:masterfrom
Conversation
- Added automatic bolt and pmt-id labels on output mask - Added a temporary PMT-ID input for labelling - Changed multiplier in `ret_centres`: `L=int(r*1.5)` (Image was being cropped otherwise) - Temporarily readded drawing detected bolt centres on mask to make sure they're being detected properly. Tested using masks with radius 120 for the PMT and 10 for the bolts.
Created two simple PMT masks using radius 120 for the PMT and 10 for the bolts. I used these to test my code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ret_centres:L=int(r*1.5)(Image was being cropped otherwise)Tested using masks with radius 120 for the PMT and 10 for the bolts.
The biggest addition is the automatic bolt number label positioning, I need to make sure that it works universally.
I created two simple PMT masks using radius 120 for the PMT and 10 for the bolts. I used these to test my code. These can be found in
DemoImages.zip