caja-directory.c: Fix memory leak.#1528
Conversation
When creating a new file (using a template, for instance), file-> details->is_added could potentially be FALSE, and cause this file to not be finalized along with other files if the view directory is destroyed. This can cause issues when re-entering that directory, with the file being in an undefined state, and could prevent the view from fully loading the location (this is identical behavior to that described in mate-desktop/python-caja#64. To reproduce: - Create an svg file and save in ~/Templates. - Right-click, Create document-> svg file, name it whatever. - Navigate out of the folder. - Modify the file in a visible manner. - Re-enter the folder, note that it never finishes loading. Ref: linuxmint/nemo#2736
|
When cropping an image to a different shape with gimp and having navigated out of the directory, it loaded right back up when I navigated back into that directory. I don't have Templates so i used another, though that should have no effect. Thus I could not duplicate the bug |
lukefromdc
left a comment
There was a problem hiding this comment.
Builds and runs fine, no problem with reloading the thumbnail after changing the file contents, though that worked with master as well on my system. Someone who can duplicate the issue should test this
|
This may have fixed another similar problem, which may have been an instance of the test case: when rendering out a video file to the desktop or doing another job where a file is not readable until an extended job is done (including some transfers to flash media), the thumbnail would never finish loading and hang on the "clock" thumbnail. With this installed, the thumbnail came up as soon as a test video render job finished. Thus we now have duplication of the issue and this fixed it. |
|
Will merge this as it works and nobody else seems to be paying attention to it |
|
Travis error is same Fedora problem |
When creating a new file (using a template, for instance), file->
details->is_added could potentially be FALSE, and cause this file to
not be finalized along with other files if the view directory is
destroyed.
This can cause issues when re-entering that directory, with the file
being in an undefined state, and could prevent the view from fully
loading the location (this is identical behavior to that described
in mate-desktop/python-caja#64.
To reproduce:
Ref:
linuxmint/nemo#2736