Conversation
|
I'm only able to add 1 reviewer in this pull request, does anyone know why that might be the case? @sameagen-MW, can you review the pull request as well? |
Huh, that's interesting. I haven't seen that before and am not sure why that would be the case. Sorry I missed this message before, I'm happy to also review the change |
sameagen-MW
left a comment
There was a problem hiding this comment.
Looks good to me, although I didn't look super closely at all of the files which were just copied over with no other changes.
I do notice that there's a message in the actions run which might indicate that the plugins aren't getting packaged correctly, here:
https://github.com/matlab-actions/common-utils/actions/runs/19126939215/job/54658903185?pr=1#step:4:34
Could you check up on that to make sure that it's not an issue? Other than that, looks ready to go!
There was a problem hiding this comment.
I'm still not a fan of the integration testing style approach where we have to use test data to cover all branches and code paths. It also causes us to keep basically 3 copies of any test data file we make for each platform. The code changes look good though.
Summary
This PR includes:
Details
This feature creates an in-platform summary for MATLAB test results if the user has a MATLAB Test license. Subsequent changes in other actions-repo will follow.
Key highlights:
P.S. These utility functions would be utilized in run-command, run-tests and run-build actions to the generate test results summary
Some additional changes:
Old:

New:
