Conversation
james-hill-matomo
requested changes
Feb 3, 2026
james-hill-matomo
left a comment
james-hill-matomo
left a comment
There was a problem hiding this comment.
LGTM, except for the extra pre-push file.
As an improvement, see Lachlan's new pre-push file, but that's a nitpick. https://github.com/innocraft/plugin-CrashAnalytics/pull/94
AltamashShaikh
commented
Feb 4, 2026
AltamashShaikh
commented
Feb 4, 2026
Contributor
Author
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Left 1 comment around test, rest looks good to me
| $alerts = $this->model->getTriggeredAlerts(array($this->idSite, $this->idSite2), 'userA'); | ||
| $this->assertCount(3, $alerts); | ||
|
|
||
| $this->model->deleteTriggeredAlertsForUserAndSites($alertIdA, array($this->idSite, $this->idSite2), 'userA'); |
Contributor
Author
There was a problem hiding this comment.
@lachiebol Can we trigger the UsersManager.removeSiteAccess from here ? or add a similar unit test ?
Piwik::postEvent('UsersManager.removeSiteAccess',[[$idsites], $userLogin]);
james-hill-matomo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds PHPStan, [no_release]
Issue No
Steps to Replicate the Issue
Checklist