Add match structure object for safer HTML wrapping of strings#17
Open
wolfd wants to merge 3 commits intomattyork:masterfrom
Open
Add match structure object for safer HTML wrapping of strings#17wolfd wants to merge 3 commits intomattyork:masterfrom
wolfd wants to merge 3 commits intomattyork:masterfrom
Conversation
Owner
|
Thanks for the PR. Investigating this. The problem it solves is definitely worth solving, but not sure this is the best approach. Created issue #26 to track this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be a bit overkill, but returning an array of little objects containing whether each character is a match allows for easier parsing of the structure in other applications.
I have a use case where I need to transform the example
<b></b>tags into React components, which is possible by parsing through the string, finding matching tags, and replacing them with React components, but the original library is where this code should be.The added single variable and if statement added to the main loop of the program will slightly degrade performance, but I believe the cost/benefit ratio is worth it for other people considering the fuzzy library.