Skip to content

[WIP] add dict support to back-cover to support any languages#20

Draft
felixbd wants to merge 4 commits intomaucejo:mainfrom
felixbd:main
Draft

[WIP] add dict support to back-cover to support any languages#20
felixbd wants to merge 4 commits intomaucejo:mainfrom
felixbd:main

Conversation

@felixbd
Copy link
Contributor

@felixbd felixbd commented Jan 11, 2026

see: #19

Tasks:

  • update back-cover func
  • update docs
  • test changes
  • check for braking changes (maybe change back-cover implementation to keep it backwards compatible)

@felixbd
Copy link
Contributor Author

felixbd commented Jan 11, 2026

maybe i move abstracts to the end of the func to be the last arg in back-cover ...

@maucejo
Copy link
Owner

maucejo commented Jan 14, 2026

I am not sure that it is worth to keep the backward compatibility, since, IMHO, it creates some inconsistencies in the API of the function. Provided that the back-cover function is properly documented in the manual, I think we can change the API of the function. What do you think about this statement?

@maucejo
Copy link
Owner

maucejo commented Jan 19, 2026

To close this PR, I propose to remove the backward compatibility. Do you agree @felixbd?

@felixbd
Copy link
Contributor Author

felixbd commented Jan 25, 2026

@maucejo Yes, I agree. I'm in the middle of exams at the moment, but I can finish it off quickly at the beginning of next month. sorry for the delay

@maucejo
Copy link
Owner

maucejo commented Jan 25, 2026

Actually, I have integrated your PR by removing the backward compatibility. But I can let you finish if you wish. Good luck for your exams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants