Skip to content

handlelinkedin: run disconnect calls in the background after error/logout #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fizzadar merged 1 commit into from
Jan 29, 2026
Merged

handlelinkedin: run disconnect calls in the background after error/logout #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/connector/handlelinkedin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,15 @@ func (l *LinkedInClient) onBadCredentials(ctx context.Context, err error) {
Error: "linkedin-bad-credentials",
Message: err.Error(),
})
l.Disconnect()
if errors.Is(err, linkedingo.ErrTokenInvalidated) {
l.userLogin.Metadata.(*UserLoginMetadata).Cookies.Clear()
err = l.userLogin.Save(ctx)
if err != nil {
zerolog.Ctx(ctx).Err(err).Msg("failed to clear cookies after token invalidation")
}
}
// Disconnect in the background so we don't deadlock against the realtime loop which calls this
go l.Disconnect()
}

func (l *LinkedInClient) onUnknownError(ctx context.Context, err error) {
Expand All @@ -48,7 +49,8 @@ func (l *LinkedInClient) onUnknownError(ctx context.Context, err error) {
Message: err.Error(),
})
// TODO probably don't do this unconditionally?
l.Disconnect()
// Disconnect in the background so we don't deadlock against the realtime loop which calls this
go l.Disconnect()
}

func (l *LinkedInClient) onDecoratedEvent(ctx context.Context, decoratedEvent *linkedingo.DecoratedEvent) {
Expand Down