Add generated code and takeoff example#71
Open
dieguit wants to merge 4 commits intomavlink:developfrom
Open
Conversation
Collaborator
|
Wow, that's amazing! Thanks for your work. Looking forward to giving it a try. |
|
Great new PR! What about merging it? 😊 I'm trying to get to drones and Rust at the same time... and any improvements to this library are very helpful for me 🙂 |
Collaborator
|
Right, I'm not really the maintainer here, so I was leaving it to @danieleades or @irsdkv to merge. Also, CI seems to fail, so that's something to check before merging, I assume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds generated rust files for every plugin, and allows access to the full grpc api with type safety.
Instead of manually writing rust code for every service, request and response, it exposes the client generated by
tonic_build. Making the library unopinionated and 100% dependant on the grpc server definitions. I consider this approach more mantainable, as there is already some effort in the mavlink organization to keep the mavlink_server and it's proto files running correctly for other SDK wrappers.I also added an example for takeoff and land, where multiple plugins are tested at the same time.
There have been previous discussions about using FFI, I did a quick test and I was not able to get the bindings working correctly, so if somebody with C++ experience wants to help, I'd be happy to try again.