Merged
Conversation
git fetch template && git checkout template/master .github https://github.com/yandex-praktikum/go-musthave-diploma-tpl.git
module github.com/Yandex-Practicum/go-autotests go 1.22.1 toolchain go1.22.5 require ( github.com/go-resty/resty/v2 v2.7.0 github.com/goccy/go-yaml v1.12.0 github.com/gofrs/uuid v4.3.0+incompatible github.com/google/pprof v0.0.0-20220829040838-70bd9ae97f40 github.com/jackc/pgx v3.6.2+incompatible github.com/jingyugao/rowserrcheck v1.1.1 github.com/stretchr/testify v1.8.0 github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966 golang.org/x/sync v0.8.0 golang.org/x/tools v0.24.0 honnef.co/go/tools v0.5.1 ) это приводит к ошибкам: Run go vet -vettool=$(which statictest) ./... # internal/unsafeheader statictest: package requires newer Go version go1.23 # internal/goarch statictest: package requires newer Go version go1.23 # internal/cpu statictest: package requires newer Go version go1.23 # internal/abi
golines -w -m 120 --shorten-comments .
…el()` will not run (gocritic)
…hermart/logging.go:32:6: undefined: envFileLoaded (typecheck) package main 1 issues: * typecheck: 1
Bazys
approved these changes
Feb 11, 2025
Bazys
left a comment
Bazys
left a comment
There was a problem hiding this comment.
мелкий вопрос, не влияющий на итог.
а в целом понравилось, очень зрелый код
…ые и код. Добавлены новые логи для отслеживания работы воркеров.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Предварительная реализация сервиса gophermart согласно спецификации.
Реализованы все требуемые маршруты.
Кол-во воркеров для синхронизации статусов расчета балов с сервисом расчета баллов: 2 шт.
Интервал проверки статуса начисления: 10 сек.
Тесты: