This repository was archived by the owner on Nov 4, 2019. It is now read-only.
Fix storing changes in WikiPage for Python3#33
Open
eseifert wants to merge 1 commit intomblayman:masterfrom
Open
Fix storing changes in WikiPage for Python3#33eseifert wants to merge 1 commit intomblayman:masterfrom
eseifert wants to merge 1 commit intomblayman:masterfrom
Conversation
WikiPage.store() method should call str.encode() after replacing newline characters. Otherwise, under Python 3 it will fail with TypeError: 'str' does not support the buffer interface
Owner
|
@eseifert thank you for your contribution! I noticed that these lines don't have any test coverage. Would you be able to write a test for this? It would help prove that this works on Python 2 and Python 3. Also, feel free to add yourself to the AUTHORS file. Let me know if you have any questions. Thanks! |
Owner
|
I can't prove that this doesn't break Python 2 without some tests. The project is getting very light maintenance from me so I'm afraid I'll have to close this unless it can be verified for Python 2 and 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WikiPage.store() method should call str.encode() after replacing newline characters. Otherwise, under Python 3 it will fail with
TypeError: 'str' does not support the buffer interface