Open
Conversation
Use the ? operator to replace try! calls
Change uses of std data structures to equivalents from core, alloc, and hashbrown
Author
|
Ping @mbr: are you still maintaining this crate? |
|
oh hey just saw your work here @rmsyn - and the PR in part overlaps with #7 / #8 I would fork this to @platform-system-interface, but the way the crates registry works would force me to give it a new name. Org namespaces are not supported (deliberately), so I'd give it a prefix, e.g., |
Author
|
That sounds good to me, just let me know what you decide on. |
|
so many projects... I have not forgotten this one, just got a bit lost with everything else. 😅 I shall rebase onto your changes :) |
|
I had originally forked it under my name, now moved here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove uses of
stddata structures with their equivalents incore,alloc, andhashbrown.Also replaces the use of deprecated
try!()calls with the?operator.Resolves #6