fix(SF2.0/UpcomingDepartures): Better readout for early and delayed CR trips #2891
+153
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Scope
Asana Ticket: [SF/UD] 👂🐞 Crossed out "scheduled at" CR times are read out as regular times
Implementation
{:scheduled_at, time}arrival substatus with{:delayed_from, time}and{:early_from, time}, since even though the visual display is the same for both, the readout is different.aria-labels to the substatus components of "Delayed from time" and "Early; Originally scheduled at time".Screenshots
Delayed
Early
How to test
Find a trip* that's running early or late. Right-click on the HH:MM
hh:mmdisplay and inspect accessibility attributes (in Firefox at least - I'm not sure how to do this in Chrome or Safari). OR navigate through the page with a screen reader.*Finding a trip can be a bit annoying. I usually go either linearly or randomly through the list of CR routes, and for each route/direction combo, I look at the second-to-last stop. If there are any trips with realtime info, then I look to see where they are now, go to that stop, and then look at each stop progressing as the train would until I find a stop that matches what I'm looking for (I start where the train currently is because predictions seem to be more likely to be "on time" when they're further away from where the train actually is).