Adding eslint, prettier and phpcs to the project.#2
Open
ryanwelcher wants to merge 8 commits intomburridge:mainfrom
Open
Adding eslint, prettier and phpcs to the project.#2ryanwelcher wants to merge 8 commits intomburridge:mainfrom
ryanwelcher wants to merge 8 commits intomburridge:mainfrom
Conversation
…ith dependencies while installing the prettier alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mburridge as we discussed, this PR adds some code quality tools and related scripts to make formatting to best practices easier.
Overview of changes:
package.jsonto force the use of the correctprettierfork the WordPress project usescomposer.jsonfile to install PHPCS and provide some linting commandsphpcs.xmlto allow the IDE to scan PHP code for issuesformat:jscommand to scan and fix any issues in JSsetupcommand to install NPM and composer dependencies all at one.