[WIP] Fix MCServerChunkGenerator

[Astro-Johnny]

Hello! I've set out to fix the MCServerChunkGenerator that appears to be just partially migrated to mceditlib API. But the changes aren't quite that straightforward so I opened this WIP pull request for discussions.

TODO list:

• Pass seed correctly.
• Generating other dimensions?
• Unloading tempWorld?
• Handling of different generatorName worlds
• ...

[Astro-Johnny]

Question 1: Is setting seed to a new world as done in 20ab0da the correct/intended way to go?

[Astro-Johnny]

Question 2: Does this piece of code:

mcedit2/src/mceditlib/minecraft_server.py

Lines 342 to 347 in 4bb98da

	if level.dimNo == 0:
	properties["allow-nether"] = "false"
	else:
	tempWorld = tempWorld.getDimension(level.dimNo)
	properties["allow-nether"] = "true"

imply that generation of different dimensions are possible? I was under impression that spawn point in vanilla Minecraft must always be on Overworld, thus only Overworld can be generated by approach the MCServerChunkGenerator takes. Is this true?

If it is true, then what's the intended purpose of the mentioned piece of code?

[Astro-Johnny]

Question 3: What's the purpose of the following line in generateAtPositionIter()?

mcedit2/src/mceditlib/minecraft_server.py

Line 364 in 4bb98da

tempWorld.unload()

The WorldEditor has no unload() method. What's the appropriate substitute? Closing and reopening, maybe?

[Kadack]

I can't open my world 1.16.3 in mcedit2 and mcedit1 i rinitialised my computer after i can't open any world was created in 1.15 and + idk for 1.14 i can open 1.8 save

An error occurred while opening C:\Users\user\AppData\Roaming.minecraft\saves\tr bedrock
'NoneType' object is not iterable

Traceback (most recent call last):
File "mcedit2\editorapp.py", line 790, in loadFile (self is a MCEditApp)
File "mcedit2\editorsession.py", line 419, in init (self is a EditorSession)
File "mcedit2\editorsession.py", line 724, in setConfiguredBlocks (self is a EditorSession)
File "mcedit2\editorsession.py", line 728, in reloadModels (self is a EditorSession)
File "src\mcedit2\rendering\blockmodels.pyx", line 236, in mcedit2.rendering.blockmodels.BlockModels.init
File "src\mcedit2\rendering\blockmodels.pyx", line 278, in mcedit2.rendering.blockmodels.BlockModels.loadModelParts
TypeError: 'NoneType' object is not iterable

[Astro-Johnny]

Hello @Kadack,
thanks for the report, but you're out of luck. MCEdit officially supports only Minecraft world versions up to 1.11 (see website). There hasn't been any progress on MCEdit2 for 3 years, and issue tracker (where your report should've gone into) for this project has been disabled. It's unlikely that anyone will take action on this. Until this changes, please look for other extant Minecraft level editors.

This particular pull request if for fixing chunk generator which appears to have been broken during MCEdit 1 to MCEdit2 transition. I set out to fix it, but with lack of response from the project owner, I haven't been actively pursuing it anymore.

This is not the place to report issues with MCEdit2. But with issue tracker gone, it appears that there is no such place anymore.