Rotation of 3 points in 3D implemented and covered by tests.#35
Open
PolarNick239 wants to merge 3 commits intomcquay239:masterfrom
Open
Rotation of 3 points in 3D implemented and covered by tests.#35PolarNick239 wants to merge 3 commits intomcquay239:masterfrom
PolarNick239 wants to merge 3 commits intomcquay239:masterfrom
Conversation
Only interval and rational calculation implemented correctly. Double arithmetic calculation implemented WRONG! (test will fail, if you will uncomment double-arithmetic optimisation) It seems, that I was wrong in eps calcultaion. My calculations - https://www.dropbox.com/s/6ntftgxuld53clz/19_3.jpeg?dl=0 But orientation of 3D points is usable - but it can be a bit slow (interval and rational arithmetic driven).
include/cg/primitives/point.h
Outdated
Collaborator
There was a problem hiding this comment.
Антон вам еще не рассказал, почему 3 пробела хорошо, а 4 плохо?)
Author
There was a problem hiding this comment.
Нет :)
Предположение - чтобы не было споров?
Или у четырех есть фатальный недостаток?
Collaborator
There was a problem hiding this comment.
Есть. Четыре пробела слишком большой отступ, а два слишком маленький :) Надо поправить на три.
Author
There was a problem hiding this comment.
Ну елки-палки. Это какой-то мрак. Стандарты ведь есть, IDE ведь должны бы быть (а с этого года и для плюсов). Сейчас испорчу на три.
Author
|
В чем у меня бага в рассчете доверительного диапазона? (мои тесты падают, если этап на чистых double включить) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only interval and rational calculation implemented correctly.
Double arithmetic calculation implemented WRONG! (test will fail, if you will uncomment double-arithmetic optimisation) It seems, that I was wrong in eps calcultaion. My calculations - https://www.dropbox.com/s/6ntftgxuld53clz/19_3.jpeg?dl=0
But orientation of 3D points is usable - but it can be a bit slow (interval and rational arithmetic driven).