Skip to content

Conversation

@juampynr
Copy link
Contributor

@juampynr juampynr commented Feb 6, 2016

Fixes #66

@juampynr
Copy link
Contributor Author

@Berdir is there anything missing in this pull request that I should work on?

@Berdir
Copy link
Member

Berdir commented Feb 11, 2016

That's not really fixing much. There's a lot broken on that page. Sorting for example.

The main reason for that is that the code still assumes that the path is stored in the message directly. For reasons that I don't really agree with, this was changed shortly before release and the path is now in the variables.

We could switch everything that's looking at message to look at location instead.

Or we could push #47 forward, which is trying to solve this completely by having our own table to track 404's that support things like dealing with multiple languages and avoiding a dependency on the dblog module. Would be great to push that forward, has a review from me that needs to be addressed.

@juampynr
Copy link
Contributor Author

I like the idea of #47, but from my experience dblog has been always replaced by syslog in production environments, which makes this feature useles. What if we simply remove this feature for good?

@Berdir
Copy link
Member

Berdir commented Feb 12, 2016

That's the one of the reasons for doing #47. We completely remove our dependency on dblog.module and you can enable or disable it separately from that.

@juampynr
Copy link
Contributor Author

Ok then!
On Feb 12, 2016 12:50 PM, "Sascha Grossenbacher" notifications@github.com
wrote:

That's the one of the reasons for doing #47
#47. We completely remove
our dependency on dblog.module and you can enable or disable it separately
from that.


Reply to this email directly or view it on GitHub
#84 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants