[#51] Add permission to administer Redirect settings #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2016
Contributor
Author
|
@Berdir is there anything missing in this pull request that I should work on? |
Member
|
Usually, an administer permission can do everything. That's a pretty common pattern. I'm not sure I like changing that. What if we turn it around and introduce something like a "manage redirects" permission and update the titles/descriptions so that it's clear that administer allows access to the settings and redirects, while the second permission only allows to manage redirects? |
Contributor
Author
|
That makes sense to me. Updating pull request now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #51.
Based on #65.