Open
Conversation
Contributor
Author
|
Closes #6 |
Contributor
Author
…t not persons.name)
ArvsIndrarys
force-pushed
the
feature/nested_paths
branch
from
22892fe to
127b77a
Compare
The production of a cache.dat file could be obscure so it is renamed to routing_cache.dat. The tests did not use the value of that constant causing errors in case it was changed.
The first case was removed in Jest->Mocha PR . The second test is an edge case test.
Had to separate the code of the route generation from the generate() function. Generate() now only sets the options on the route loaded from cache.
Now occurs doing `new Routing(opts)` instead on the `generate(routeDef)` call.
Contributor
Author
|
No follows the specification correction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache and Nested path functionnality