fix issue with string-list options #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the -jslibs command-line option was not working correctly with MLB files. The fix involves generalizing a function that identifies source file extensions to include "mlb" files in addition to "sml" and "sig" files.
Changes:
- Renamed
has_sml_source_exttois_source_extto reflect its broader scope - Added "mlb" as a recognized source extension alongside "sml" and "sig"
- Updated all function references and added documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Common/FLAGS.sig | Updated function signature from has_sml_source_ext to is_source_ext and added documentation |
| src/Common/Flags.sml | Renamed function and added "mlb" case; updated reference in option parsing logic |
| src/Manager/Manager.sml | Updated function call to use new is_source_ext name |
| NEWS_SMLTOJS.md | Added release note documenting the fix for issue #172 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikkelwillen
pushed a commit
to mikkelwillen/mlkit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #172 .