Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially ports
PyWENOto usemeson-pythonhttps://meson-python.readthedocs.io to build instead of setuptools. I went withmeson-pythonbecause that seems to be whatnumpy,scipyandmatplotlibare using these days, so it's fairly well-supported.Some additional non-trivial changes:
pyproject.tomlway to configure things:setup.pyis essentially a stub now.versionandgit_version: it now relies on https://docs.python.org/3/library/importlib.metadata.html to get version information.sphinx_rtd_themeinstead so that it looks less old 😁Ran the tests and the examples and everything seems to be working fine, but it may need a careful look so it doesn't just "work on my machine".
I know
PyWENOis mostly dead, unfortunately, but I was using it to double-check another implementation and thought it would be useful fix this upstream. It was actually failing a build step because it wasn't declaringsetup_requires=["numpy"]or something like that.