-
Notifications
You must be signed in to change notification settings - Fork 223
Mute: Nodes #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute: Nodes #779
Conversation
|
@Xaositek These will need merging too alongside meshtastic/firmware#8088 |
| * True if node has been muted | ||
| * Persists between NodeDB internal clean ups | ||
| */ | ||
| bool is_muted = 14; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer to use a bit in the bitfield rather than use more device memory and flash.
| * LSB 0 of the bitfield | ||
| */ | ||
| bool is_key_manually_verified = 12; | ||
| bool is_key_manually_verified = 13; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't do this. Don't change existing numberings.
This PR adds mute settings for chats with a particular node.
Firmware changes: meshtastic/firmware#8088
Python CLI changes: meshtastic/python#822
Docs: meshtastic/meshtastic#2038
Related issues:
meshtastic/device-ui#189
meshtastic/firmware#7943
Checklist before merging